Ethan Girouard eta357
0 Followers · 4 Following
Repositories
2
 Projects Packages Public Activity Starred Repositories
11
eta357 created pull request LibreTunes/LibreTunes#133 2024-11-04 22:39:57 +00:00
Create profile page
eta357 opened issue LibreTunes/LibreTunes#132 2024-11-04 22:39:13 +00:00
Update wasm-bindgen to 0.2.95
eta357 opened issue LibreTunes/LibreTunes#131 2024-11-04 22:19:15 +00:00
Fix sidebar component height
eta357 pushed to 42-create-profile-page at LibreTunes/LibreTunes 2024-11-04 22:16:21 +00:00
f23430af73 Remove unnecessary Artist import
ef5576ab3f Create profile page
833393cb3a Add generic Error component
39dd8099cd Make ServerError a component instead of a page
5011cda8fa Allow home-component to scroll
Compare 8 commits »
eta357 closed issue LibreTunes/LibreTunes#117 2024-11-04 04:31:41 +00:00
Fix missing libretunes-images volume in Docker compose
eta357 commented on issue LibreTunes/LibreTunes#117 2024-11-04 04:31:41 +00:00
Fix missing libretunes-images volume in Docker compose

Duplicate of #119, already done. Closing.

eta357 opened issue LibreTunes/LibreTunes#130 2024-11-04 04:23:30 +00:00
Standardize all media images
eta357 pushed to 42-create-profile-page at LibreTunes/LibreTunes 2024-11-04 04:22:01 +00:00
35abbe19ee Merge branch '126-create-global-logged-in-user-resource' into 42-create-profile-page
2b380d7787 Refetch logged in user on login/signup
8ac3a87c58 Add global logged in user Resource
43a5b519fd Add API endpoint to get logged in user
251d567863 Return logged in user from login endpoint
Compare 47 commits »
eta357 opened issue LibreTunes/LibreTunes#129 2024-11-04 02:49:32 +00:00
Enable scrolling for home components
eta357 deleted branch 126-create-global-logged-in-user-resource from LibreTunes/LibreTunes 2024-11-03 22:23:35 +00:00
eta357 pushed to main at LibreTunes/LibreTunes 2024-11-03 22:23:34 +00:00
186c622e6f Merge pull request 'Create global logged in user resource' (#128) from 126-create-global-logged-in-user-resource into main
2b380d7787 Refetch logged in user on login/signup
8ac3a87c58 Add global logged in user Resource
43a5b519fd Add API endpoint to get logged in user
251d567863 Return logged in user from login endpoint
Compare 5 commits »
eta357 closed issue LibreTunes/LibreTunes#126 2024-11-03 22:23:33 +00:00
Create global logged in user resource
eta357 merged pull request LibreTunes/LibreTunes#128 2024-11-03 22:23:33 +00:00
Create global logged in user resource
eta357 created pull request LibreTunes/LibreTunes#128 2024-11-03 22:23:19 +00:00
Create global logged in user resource
eta357 opened issue LibreTunes/LibreTunes#127 2024-11-03 22:22:23 +00:00
Switch from dotenv to dotenvy
2b380d7787 Refetch logged in user on login/signup
8ac3a87c58 Add global logged in user Resource
43a5b519fd Add API endpoint to get logged in user
251d567863 Return logged in user from login endpoint
Compare 4 commits »
eta357 commented on issue LibreTunes/LibreTunes#126 2024-11-03 21:18:39 +00:00
Create global logged in user resource

!start

eta357 opened issue LibreTunes/LibreTunes#126 2024-11-03 21:18:29 +00:00
Create global logged in user resource
eta357 commented on pull request LibreTunes/LibreTunes#124 2024-11-03 18:08:57 +00:00
95-fix-home-screen-account-button-ui

I think you were right originally about having a global logged in user object on the frontend. I can help with the development of this. Adding this would make writing several other pages easier…

eta357 commented on pull request LibreTunes/LibreTunes#124 2024-11-03 18:06:56 +00:00
95-fix-home-screen-account-button-ui

Turning this into an API endpoint is actually dangerous, as the returned user contains the password hash. This field should be set to None before returning. Although technically the user is only returned if that user has already logged in (and therefore should already know the password), this is still not a good practice. I know I advised you to use this function, but we should add this protection. However this code may change anyways, see my other comment about potentially adding a new function returning an Option<User>.