LibreTunes/LibreTunes
7
1
Fork 0
Code Issues 24 Pull Requests Actions Packages Releases Activity

111-create-playlist-database-tables #137

Merged
eta357 merged 4 commits from 111-create-playlist-database-tables into main 2024-11-12 22:21:53 +00:00
Conversation 3 Commits 4 Files Changed 4 +65
clbertolini commented 2024-11-08 21:36:02 +00:00
Member
Copy Link
No description provided.
clbertolini added 2 commits 2024-11-08 21:36:02 +00:00
Create playlist database migration 81b1490cce
Created model
All checks were successful
Push Workflows / docs (push) Successful in 4m11s
Details
Push Workflows / test (push) Successful in 6m6s
Details
Push Workflows / leptos-test (push) Successful in 8m13s
Details
Push Workflows / build (push) Successful in 8m56s
Details
Push Workflows / docker-build (push) Successful in 16m31s
Details
0335e3d255
LibreTunes-Bot added the
backend
status
in review
 labels 2024-11-08 21:36:03 +00:00
clbertolini was assigned by LibreTunes-Bot 2024-11-08 21:36:04 +00:00
LibreTunes-Bot commented 2024-11-08 21:36:04 +00:00
Member
Copy Link

This PR resolves #111.

This PR resolves #111.
eta357 requested review from eta357 2024-11-11 20:26:30 +00:00
eta357 requested changes 2024-11-11 20:26:40 +00:00
Dismissed
eta357 left a comment
Owner
Copy Link

I should have warned you about this before, but unfortunately the time crate doesn't have full functionality on WASM, so I had to switch to using chronos and this involves changing some of the time/data datatypes in models. What we'll need to do here is merge my branch 134-fix-time-not-implemented-on-wasm into this one and change the types in models.rs a bit. I can do this or you can if you want.

I should have warned you about this before, but unfortunately the time crate doesn't have full functionality on WASM, so I had to switch to using chronos and this involves changing some of the time/data datatypes in models. What we'll need to do here is merge my branch [`134-fix-time-not-implemented-on-wasm`]([url](https://gitea.mregirouard.com/LibreTunes/LibreTunes/src/branch/134-fix-time-not-implemented-on-wasm)) into this one and change the types in `models.rs` a bit. I can do this or you can if you want.
clbertolini added 2 commits 2024-11-12 22:09:31 +00:00
Merge remote-tracking branch 'origin/134-fix-time-not-implemented-on-wasm' into 111-create-playlist-database-tables 74044f2e17
Change Playlist Model to use chronos time
Some checks failed
Push Workflows / docs (push) Successful in 4m38s
Details
Push Workflows / docker-build (push) Failing after 5m13s
Details
Push Workflows / test (push) Successful in 6m52s
Details
Push Workflows / leptos-test (push) Successful in 9m55s
Details
Push Workflows / build (push) Successful in 10m52s
Details
7f298f75ce
eta357 requested review from eta357 2024-11-12 22:21:09 +00:00
eta357 approved these changes 2024-11-12 22:21:46 +00:00
eta357 merged commit d09060959a into main 2024-11-12 22:21:53 +00:00
LibreTunes-Bot added
status
done
 and removed
status
in review
 labels 2024-11-12 22:21:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
eta357
Labels
Clear labels
backend
Pertaining to the API or back end of the web app
cicd
Relating to continuous integration / continuous deployment
dependencies
docs
Documentation work
frontend
Related to the UI or front end of the web app
meta
Related to the project itself
status
done
Work has been completed
status
in progress
Work is in progress
status
in review
Under review to be merged
status
todo
Work is planned, but has not yet started
type
bug
An issue with an existing feature
type
feature
A new feature
No Label
backend
status
done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clbertolini dannyzou18 ecco257 eta357 hifwiend LibreTunes-Bot pubsafe
No Assignees clbertolini
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LibreTunes/LibreTunes#137
No description provided.
Delete Branch "111-create-playlist-database-tables"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?